From 1a5ab33852b1ef301d6a3ce4c3154d430ef24a03 Mon Sep 17 00:00:00 2001
From: Jade Ellis <jade@ellis.link>
Date: Fri, 25 Apr 2025 23:51:23 +0100
Subject: [PATCH] chore: Error on missing ID in messages

---
 src/api/client/message.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/api/client/message.rs b/src/api/client/message.rs
index bedfdc7a..16b1796a 100644
--- a/src/api/client/message.rs
+++ b/src/api/client/message.rs
@@ -1,3 +1,5 @@
+use core::panic;
+
 use axum::extract::State;
 use conduwuit::{
 	Err, Result, at,
@@ -132,8 +134,6 @@ pub(crate) async fn get_message_events_route(
 		.take(limit)
 		.collect()
 		.await;
-	// let appservice_id = body.appservice_info.map(|appservice|
-	// appservice.registration.id);
 
 	let lazy_loading_context = lazy_loading::Context {
 		user_id: sender_user,
@@ -143,7 +143,7 @@ pub(crate) async fn get_message_events_route(
 				if let Some(registration) = body.appservice_info.as_ref() {
 					<&DeviceId>::from(registration.registration.id.as_str())
 				} else {
-					<&DeviceId>::from("")
+					panic!("No device_id provided and no appservice registration found, this should be unreachable");
 				},
 		},
 		room_id,