magmaus3/continuwuity
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

use HTTP 403 (forbidden) instead of HTTP 400 for membership failed auth checks

Browse source 
Signed-off-by: strawberry <strawberry@puppygock.gay>
This commit is contained in:
strawberry 2024-04-23 18:59:14 -04:00 • committed by June
parent 73c67d6b17
commit 1b41e35f1d
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/api/client_server/membership.rs
View file

@ -967,7 +967,7 @@ pub(crate) async fn join_room_by_id_helper(
.add_pdu_outlier(&event_id, &value)?; .add_pdu_outlier(&event_id, &value)?;
} }
info!("Running send_join auth check"); debug!("Running send_join auth check");
let auth_check = state_res::event_auth::auth_check( let auth_check = state_res::event_auth::auth_check(
&state_res::RoomVersion::new(&room_version_id).expect("room version is supported"), &state_res::RoomVersion::new(&room_version_id).expect("room version is supported"),
@ -991,11 +991,11 @@ pub(crate) async fn join_room_by_id_helper(
) )
.map_err(|e| { .map_err(|e| {
warn!("Auth check failed: {e}"); warn!("Auth check failed: {e}");
Error::BadRequest(ErrorKind::InvalidParam, "Auth check failed") Error::BadRequest(ErrorKind::forbidden(), "Auth check failed")
})?; })?;
if !auth_check { if !auth_check {
return Err(Error::BadRequest(ErrorKind::InvalidParam, "Auth check failed")); return Err(Error::BadRequest(ErrorKind::forbidden(), "Auth check failed"));
} }
info!("Saving state from send_join"); info!("Saving state from send_join");