From 1d1ccec532bf3eaebf499d3ff4c9f7a24369c389 Mon Sep 17 00:00:00 2001
From: June Clementine Strawberry <june@3.dog>
Date: Tue, 11 Mar 2025 23:05:56 -0400
Subject: [PATCH] fix some nightly clippy lints

Signed-off-by: June Clementine Strawberry <june@3.dog>
---
 Cargo.toml                | 3 +++
 clippy.toml               | 3 ++-
 src/admin/processor.rs    | 8 +++++---
 src/api/client/account.rs | 4 ++--
 src/api/client/state.rs   | 2 +-
 src/core/utils/string.rs  | 1 +
 6 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/Cargo.toml b/Cargo.toml
index 2bf30d61..fd477850 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -841,6 +841,9 @@ unused_crate_dependencies = "allow"
 unsafe_code = "allow"
 variant_size_differences = "allow"
 
+# we check nightly clippy lints
+unknown_lints = "allow"
+
 #######################################
 #
 # Clippy lints
diff --git a/clippy.toml b/clippy.toml
index 42427101..863759aa 100644
--- a/clippy.toml
+++ b/clippy.toml
@@ -2,9 +2,10 @@ array-size-threshold = 4096
 cognitive-complexity-threshold = 94         # TODO reduce me ALARA
 excessive-nesting-threshold = 11            # TODO reduce me to 4 or 5
 future-size-threshold = 7745                # TODO reduce me ALARA
-stack-size-threshold = 196608               # reduce me ALARA
+stack-size-threshold = 196608               # TODO reduce me ALARA
 too-many-lines-threshold = 780              # TODO reduce me to <= 100
 type-complexity-threshold = 250             # reduce me to ~200
+large-error-threshold = 256                 # TODO reduce me ALARA
 
 disallowed-macros = [
 	{ path = "log::error", reason = "use conduwuit_core::error" },
diff --git a/src/admin/processor.rs b/src/admin/processor.rs
index 77a60959..53a15098 100644
--- a/src/admin/processor.rs
+++ b/src/admin/processor.rs
@@ -91,6 +91,7 @@ async fn process_command(services: Arc<Services>, input: &CommandInput) -> Proce
 	}
 }
 
+#[allow(clippy::result_large_err)]
 fn handle_panic(error: &Error, command: &CommandInput) -> ProcessorResult {
 	let link =
 		"Please submit a [bug report](https://github.com/girlbossceo/conduwuit/issues/new). 🥺";
@@ -100,7 +101,7 @@ fn handle_panic(error: &Error, command: &CommandInput) -> ProcessorResult {
 	Err(reply(content, command.reply_id.as_deref()))
 }
 
-// Parse and process a message from the admin room
+/// Parse and process a message from the admin room
 async fn process(
 	context: &Command<'_>,
 	command: AdminCommand,
@@ -164,7 +165,8 @@ fn capture_create(context: &Command<'_>) -> (Arc<Capture>, Arc<Mutex<String>>) {
 	(capture, logs)
 }
 
-// Parse chat messages from the admin room into an AdminCommand object
+/// Parse chat messages from the admin room into an AdminCommand object
+#[allow(clippy::result_large_err)]
 fn parse<'a>(
 	services: &Arc<Services>,
 	input: &'a CommandInput,
@@ -232,7 +234,7 @@ fn complete_command(mut cmd: clap::Command, line: &str) -> String {
 	ret.join(" ")
 }
 
-// Parse chat messages from the admin room into an AdminCommand object
+/// Parse chat messages from the admin room into an AdminCommand object
 fn parse_line(command_line: &str) -> Vec<String> {
 	let mut argv = command_line
 		.split_whitespace()
diff --git a/src/api/client/account.rs b/src/api/client/account.rs
index 2b8209d4..32438098 100644
--- a/src/api/client/account.rs
+++ b/src/api/client/account.rs
@@ -109,7 +109,7 @@ pub(crate) async fn get_register_available_route(
 		if !info.is_user_match(&user_id) {
 			return Err!(Request(Exclusive("Username is not in an appservice namespace.")));
 		}
-	};
+	}
 
 	if services.appservice.is_exclusive_user_id(&user_id).await {
 		return Err!(Request(Exclusive("Username is reserved by an appservice.")));
@@ -159,7 +159,7 @@ pub(crate) async fn register_route(
 			| (None, _) => {
 				info!(%is_guest, "Rejecting registration attempt as registration is disabled");
 			},
-		};
+		}
 
 		return Err!(Request(Forbidden("Registration has been disabled.")));
 	}
diff --git a/src/api/client/state.rs b/src/api/client/state.rs
index db79735f..9563c26d 100644
--- a/src/api/client/state.rs
+++ b/src/api/client/state.rs
@@ -254,7 +254,7 @@ async fn allowed_to_send_state_event(
 						"Room server ACL event is invalid: {e}"
 					))));
 				},
-			};
+			}
 		},
 		| StateEventType::RoomEncryption =>
 		// Forbid m.room.encryption if encryption is disabled
diff --git a/src/core/utils/string.rs b/src/core/utils/string.rs
index 9340d009..d8fa3f95 100644
--- a/src/core/utils/string.rs
+++ b/src/core/utils/string.rs
@@ -60,6 +60,7 @@ pub fn camel_to_snake_string(s: &str) -> String {
 }
 
 #[inline]
+#[allow(clippy::unbuffered_bytes)] // these are allocated string utilities, not file I/O utils
 pub fn camel_to_snake_case<I, O>(output: &mut O, input: I) -> Result<()>
 where
 	I: std::io::Read,