From 60605e95795caef5b692562791002526654009c9 Mon Sep 17 00:00:00 2001 From: strawberry Date: Sun, 1 Sep 2024 00:59:43 -0400 Subject: [PATCH] remove unnecessary loop/allocations on CIDR range init Signed-off-by: strawberry --- src/service/globals/mod.rs | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/src/service/globals/mod.rs b/src/service/globals/mod.rs index 05fe1a77..c82d3097 100644 --- a/src/service/globals/mod.rs +++ b/src/service/globals/mod.rs @@ -76,12 +76,15 @@ impl crate::Service for Service { // Experimental, partially supported room versions let unstable_room_versions = vec![RoomVersionId::V2, RoomVersionId::V3, RoomVersionId::V4, RoomVersionId::V5]; - let mut cidr_range_denylist = Vec::new(); - for cidr in config.ip_range_denylist.clone() { - let cidr = IPAddress::parse(cidr).expect("valid cidr range"); - trace!("Denied CIDR range: {:?}", cidr); - cidr_range_denylist.push(cidr); - } + let cidr_range_denylist: Vec<_> = config + .ip_range_denylist + .iter() + .map(|cidr| { + let cidr = IPAddress::parse(cidr).expect("valid cidr range"); + trace!("Denied CIDR range: {:?}", cidr); + cidr + }) + .collect(); let mut s = Self { db,