From 6aaf169c45e6125df5fe5723373fbe541a5f1b2c Mon Sep 17 00:00:00 2001
From: strawberry <strawberry@puppygock.gay>
Date: Wed, 27 Mar 2024 14:44:59 -0400
Subject: [PATCH] fix wrong order of logic, prefer room alias server first if
 available

Signed-off-by: strawberry <strawberry@puppygock.gay>
---
 src/api/client_server/alias.rs | 37 ++++++++++++++++++++++------------
 1 file changed, 24 insertions(+), 13 deletions(-)

diff --git a/src/api/client_server/alias.rs b/src/api/client_server/alias.rs
index fb117fb5..d91f7940 100644
--- a/src/api/client_server/alias.rs
+++ b/src/api/client_server/alias.rs
@@ -113,6 +113,9 @@ pub(crate) async fn get_alias_helper(room_alias: OwnedRoomAliasId) -> Result<get
 
 		let mut servers = response.servers;
 
+		// since the room alias server_name responded, insert it into the list
+		servers.push(room_alias.server_name().into());
+
 		// find active servers in room state cache to suggest
 		for extra_servers in services()
 			.rooms
@@ -123,7 +126,14 @@ pub(crate) async fn get_alias_helper(room_alias: OwnedRoomAliasId) -> Result<get
 			servers.push(extra_servers);
 		}
 
-		// insert our server as the very first choice if in list
+		servers.sort_unstable();
+		servers.dedup();
+
+		// shuffle list of servers randomly after sort and dedupe
+		servers.shuffle(&mut rand::thread_rng());
+
+		// prefer the very first server to be ourselves if available, else prefer the
+		// room alias server first
 		if let Some(server_index) = servers
 			.clone()
 			.into_iter()
@@ -131,14 +141,15 @@ pub(crate) async fn get_alias_helper(room_alias: OwnedRoomAliasId) -> Result<get
 		{
 			servers.remove(server_index);
 			servers.insert(0, services().globals.server_name().to_owned());
+		} else if let Some(alias_server_index) = servers
+			.clone()
+			.into_iter()
+			.position(|server| server == room_alias.server_name())
+		{
+			servers.remove(alias_server_index);
+			servers.insert(0, room_alias.server_name().into());
 		}
 
-		servers.sort_unstable();
-		servers.dedup();
-
-		// shuffle list of servers randomly after sort and dedupe
-		servers.shuffle(&mut rand::thread_rng());
-
 		return Ok(get_alias::v3::Response::new(room_id, servers));
 	}
 
@@ -191,6 +202,12 @@ pub(crate) async fn get_alias_helper(room_alias: OwnedRoomAliasId) -> Result<get
 		servers.push(extra_servers);
 	}
 
+	servers.sort_unstable();
+	servers.dedup();
+
+	// shuffle list of servers randomly after sort and dedupe
+	servers.shuffle(&mut rand::thread_rng());
+
 	// insert our server as the very first choice if in list
 	if let Some(server_index) = servers
 		.clone()
@@ -201,11 +218,5 @@ pub(crate) async fn get_alias_helper(room_alias: OwnedRoomAliasId) -> Result<get
 		servers.insert(0, services().globals.server_name().to_owned());
 	}
 
-	servers.sort_unstable();
-	servers.dedup();
-
-	// shuffle list of servers randomly after sort and dedupe
-	servers.shuffle(&mut rand::thread_rng());
-
 	Ok(get_alias::v3::Response::new(room_id, servers))
 }