magmaus3/continuwuity
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix needless pass by ref mut

Browse source 
Signed-off-by: Jason Volk <jason@zemos.net>
This commit is contained in:
Jason Volk 2024-06-09 06:50:44 +00:00
parent 89d7d48324
commit 7688d67870
2 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Cargo.toml
View file

@ -718,7 +718,6 @@ nursery = "warn"
future_not_send = { level = "allow", priority = 1 } # TODO future_not_send = { level = "allow", priority = 1 } # TODO
missing_const_for_fn = { level = "allow", priority = 1 } # TODO missing_const_for_fn = { level = "allow", priority = 1 } # TODO
needless_collect = { level = "allow", priority = 1 } # TODO needless_collect = { level = "allow", priority = 1 } # TODO
needless_pass_by_ref_mut = { level = "allow", priority = 1 } # TODO
option_if_let_else = { level = "allow", priority = 1 } # TODO option_if_let_else = { level = "allow", priority = 1 } # TODO
redundant_pub_crate = { level = "allow", priority = 1 } # TODO redundant_pub_crate = { level = "allow", priority = 1 } # TODO
significant_drop_in_scrutinee = { level = "allow", priority = 1 } # TODO significant_drop_in_scrutinee = { level = "allow", priority = 1 } # TODO

10
src/service/sending/sender.rs
View file

@ -60,12 +60,12 @@ impl Service {
let mut futures: SendingFutures<'_> = FuturesUnordered::new(); let mut futures: SendingFutures<'_> = FuturesUnordered::new();
let mut statuses: CurTransactionStatus = CurTransactionStatus::new(); let mut statuses: CurTransactionStatus = CurTransactionStatus::new();
self.initial_transactions(&mut futures, &mut statuses); self.initial_transactions(&futures, &mut statuses);
loop { loop {
debug_assert!(!receiver.is_closed(), "channel error"); debug_assert!(!receiver.is_closed(), "channel error");
tokio::select! { tokio::select! {
request = receiver.recv_async() => match request { request = receiver.recv_async() => match request {
Ok(request) => self.handle_request(request, &mut futures, &mut statuses), Ok(request) => self.handle_request(request, &futures, &mut statuses),
Err(_) => return Ok(()), Err(_) => return Ok(()),
}, },
Some(response) = futures.next() => { Some(response) = futures.next() => {
@ -98,7 +98,7 @@ impl Service {
} }
fn handle_response_ok( fn handle_response_ok(
&self, dest: &Destination, futures: &mut SendingFutures<'_>, statuses: &mut CurTransactionStatus, &self, dest: &Destination, futures: &SendingFutures<'_>, statuses: &mut CurTransactionStatus,
) { ) {
let _cork = services().globals.db.cork(); let _cork = services().globals.db.cork();
self.db self.db
@ -125,7 +125,7 @@ impl Service {
} }
} }
fn handle_request(&self, msg: Msg, futures: &mut SendingFutures<'_>, statuses: &mut CurTransactionStatus) { fn handle_request(&self, msg: Msg, futures: &SendingFutures<'_>, statuses: &mut CurTransactionStatus) {
let iv = vec![(msg.event, msg.queue_id)]; let iv = vec![(msg.event, msg.queue_id)];
if let Ok(Some(events)) = self.select_events(&msg.dest, iv, statuses) { if let Ok(Some(events)) = self.select_events(&msg.dest, iv, statuses) {
if !events.is_empty() { if !events.is_empty() {
@ -136,7 +136,7 @@ impl Service {
} }
} }
fn initial_transactions(&self, futures: &mut SendingFutures<'_>, statuses: &mut CurTransactionStatus) { fn initial_transactions(&self, futures: &SendingFutures<'_>, statuses: &mut CurTransactionStatus) {
let keep = usize::try_from(self.startup_netburst_keep).unwrap_or(usize::MAX); let keep = usize::try_from(self.startup_netburst_keep).unwrap_or(usize::MAX);
let mut txns = HashMap::<Destination, Vec<SendingEvent>>::new(); let mut txns = HashMap::<Destination, Vec<SendingEvent>>::new();
for (key, dest, event) in self.db.active_requests().filter_map(Result::ok) { for (key, dest, event) in self.db.active_requests().filter_map(Result::ok) {