magmaus3/continuwuity
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(fed): dont reject /get_missing_events on world readable rooms

Browse source 
Signed-off-by: strawberry <strawberry@puppygock.gay>
This commit is contained in:
strawberry 2024-06-07 01:21:01 -04:00
parent bfbb29dded
commit 81487e3f07
1 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/api/server/get_missing_events.rs
View file

@ -13,7 +13,16 @@ pub(crate) async fn get_missing_events_route(
) -> Result<get_missing_events::v1::Response> { ) -> Result<get_missing_events::v1::Response> {
let origin = body.origin.as_ref().expect("server is authenticated"); let origin = body.origin.as_ref().expect("server is authenticated");
services()
.rooms
.event_handler
.acl_check(origin, &body.room_id)?;
if !services() if !services()
.rooms
.state_accessor
.is_world_readable(&body.room_id)?
&& !services()
.rooms .rooms
.state_cache .state_cache
.server_in_room(origin, &body.room_id)? .server_in_room(origin, &body.room_id)?
@ -21,11 +30,6 @@ pub(crate) async fn get_missing_events_route(
return Err(Error::BadRequest(ErrorKind::forbidden(), "Server is not in room")); return Err(Error::BadRequest(ErrorKind::forbidden(), "Server is not in room"));
} }
services()
.rooms
.event_handler
.acl_check(origin, &body.room_id)?;
let limit = body let limit = body
.limit .limit
.try_into() .try_into()