cleanup+refactor admin room alias and server account accessing to globals

Signed-off-by: strawberry <strawberry@puppygock.gay>

src/service/globals/emerg_access.rs

@@ -2,7 +2,6 @@ use conduit::Result;
 use ruma::{
 	events::{push_rules::PushRulesEventContent, GlobalAccountDataEvent, GlobalAccountDataEventType},
 	push::Ruleset,
-	UserId,
 };
 use tracing::{error, warn};
 
@@ -18,21 +17,20 @@ pub(crate) fn init_emergency_access() {
 /// Sets the emergency password and push rules for the @conduit account in case
 /// emergency password is set
 fn set_emergency_access() -> Result<bool> {
-	let conduit_user = UserId::parse_with_server_name("conduit", services().globals.server_name())
-		.expect("@conduit:server_name is a valid UserId");
+	let conduit_user = &services().globals.server_user;
 
 	services()
 		.users
-		.set_password(&conduit_user, services().globals.emergency_password().as_deref())?;
+		.set_password(conduit_user, services().globals.emergency_password().as_deref())?;
 
 	let (ruleset, pwd_set) = match services().globals.emergency_password() {
-		Some(_) => (Ruleset::server_default(&conduit_user), true),
+		Some(_) => (Ruleset::server_default(conduit_user), true),
 		None => (Ruleset::new(), false),
 	};
 
 	services().account_data.update(
 		None,
-		&conduit_user,
+		conduit_user,
 		GlobalAccountDataEventType::PushRules.to_string().into(),
 		&serde_json::to_value(&GlobalAccountDataEvent {
 			content: PushRulesEventContent {

src/service/globals/migrations.rs

@@ -22,10 +22,9 @@ pub(crate) async fn migrations(db: &KeyValueDatabase, config: &Config) -> Result
 	// Matrix resource ownership is based on the server name; changing it
 	// requires recreating the database from scratch.
 	if services().users.count()? > 0 {
-		let conduit_user =
-			UserId::parse_with_server_name("conduit", &config.server_name).expect("@conduit:server_name is valid");
+		let conduit_user = &services().globals.server_user;
 
-		if !services().users.exists(&conduit_user)? {
+		if !services().users.exists(conduit_user)? {
 			error!("The {} server user does not exist, and the database is not new.", conduit_user);
 			return Err(Error::bad_database(
 				"Cannot reuse an existing database after changing the server name, please delete the old one first.",

src/service/globals/mod.rs

@@ -24,8 +24,8 @@ use ruma::{
 		federation::discovery::{ServerSigningKeys, VerifyKey},
 	},
 	serde::Base64,
-	DeviceId, OwnedEventId, OwnedRoomId, OwnedServerName, OwnedServerSigningKeyId, OwnedUserId, RoomVersionId,
-	ServerName, UserId,
+	DeviceId, OwnedEventId, OwnedRoomAliasId, OwnedRoomId, OwnedServerName, OwnedServerSigningKeyId, OwnedUserId,
+	RoomAliasId, RoomVersionId, ServerName, UserId,
 };
 use tokio::{
 	sync::{Mutex, RwLock},
@@ -58,6 +58,8 @@ pub struct Service {
 	pub roomid_federationhandletime: RwLock<HashMap<OwnedRoomId, (OwnedEventId, Instant)>>,
 	pub updates_handle: Mutex<Option<JoinHandle<()>>>,
 	pub stateres_mutex: Arc<Mutex<()>>,
+	pub server_user: OwnedUserId,
+	pub admin_alias: OwnedRoomAliasId,
 }
 
 impl Service {
@@ -118,6 +120,10 @@ impl Service {
 			roomid_federationhandletime: RwLock::new(HashMap::new()),
 			updates_handle: Mutex::new(None),
 			stateres_mutex: Arc::new(Mutex::new(())),
+			admin_alias: RoomAliasId::parse(format!("#admins:{}", &config.server_name))
+				.expect("#admins:server_name is valid alias name"),
+			server_user: UserId::parse_with_server_name(String::from("conduit"), &config.server_name)
+				.expect("@conduit:server_name is valid"),
 		};
 
 		fs::create_dir_all(s.get_media_folder())?;