Simplify to publish combined jemalloc image for all architectures

This commit is contained in:
Tom Foster 2024-04-20 23:54:39 +01:00 committed by June
parent 8525dda468
commit a36b37ee3d

View file

@ -290,146 +290,72 @@ jobs:
# don't compress again # don't compress again
compression-level: 0 compression-level: 0
create-and-push-manifest:
- name: Extract metadata for Dockerhub name: Create and Push Docker Manifest
env: runs-on: ubuntu-latest
REGISTRY: registry.hub.docker.com needs: build-oci
IMAGE_NAME: ${{ github.repository }}
id: meta-dockerhub steps:
uses: docker/metadata-action@v5 - name: Login to Docker Hub
with: uses: docker/login-action@v3
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} with:
username: ${{ secrets.DOCKER_USERNAME }}
- name: Extract metadata for GitHub Container Registry password: ${{ secrets.DOCKERHUB_TOKEN }}
env:
REGISTRY: ghcr.io - name: Login to GitHub Container Registry
IMAGE_NAME: ${{ github.repository }} uses: docker/login-action@v3
id: meta-ghcr with:
uses: docker/metadata-action@v5 registry: ghcr.io
with: username: ${{ github.actor }}
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} password: ${{ secrets.GITHUB_TOKEN }}
- name: Load OCI Images
- name: Login to Dockerhub run: |
env: docker load -i oci-image-x86_64-unknown-linux-musl-jemalloc.tar.gz
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }} docker load -i oci-image-aarch64-unknown-linux-musl-jemalloc.tar.gz
DOCKER_USERNAME: ${{ vars.DOCKER_USERNAME }}
if: ${{ (github.event_name != 'pull_request') && (env.DOCKER_USERNAME != '') && (env.DOCKERHUB_TOKEN != '') }} - name: Create and Push Manifest to Docker Hub
uses: docker/login-action@v3 run: |
with: DOCKER_IMAGE_NAME="docker.io/${{ github.repository }}"
# username is not really a secret BRANCH_NAME="${{ github.ref_name }}"
username: ${{ vars.DOCKER_USERNAME }} SHA_TAG="${BRANCH_NAME}-${{ github.sha }}"
password: ${{ secrets.DOCKERHUB_TOKEN }} BRANCH_TAG=$BRANCH_NAME
- name: Login to GitHub Container Registry if [ "$BRANCH_NAME" == "main" ]; then
if: github.event_name != 'pull_request' BRANCH_TAG="latest"
uses: docker/login-action@v3
env:
REGISTRY: ghcr.io
with:
registry: ${{ env.REGISTRY }}
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}
- name: Publish to Dockerhub
env:
IMAGE_SUFFIX_AMD64: amd64
IMAGE_SUFFIX_ARM64V8: arm64v8
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
DOCKER_USERNAME: ${{ vars.DOCKER_USERNAME }}
TARGET_NAME: ${{ matrix.oci-target }}
IMAGE_NAME: docker.io/${{ github.repository }}
if: ${{ (github.event_name != 'pull_request') && (env.DOCKER_USERNAME != '') && (env.DOCKERHUB_TOKEN != '') }}
run: |
docker load -i oci-image-${{ matrix.oci-target }}.tar.gz
IMAGE_ID=$(docker images -q conduit:main)
TAG_SUFFIX=${{ matrix.oci-target }}
TAG_SUFFIX=${TAG_SUFFIX//-jemalloc/}
TAG_SUFFIX=${TAG_SUFFIX//unknown-linux-musl/}
TAG_SUFFIX=${TAG_SUFFIX//aarch64/arm64v8}
TAG_SUFFIX=${TAG_SUFFIX//x86_64/amd64}
# Tag and push the architecture-specific images
docker tag $IMAGE_ID $IMAGE_NAME:$GITHUB_SHA-$TAG_SUFFIX
docker push $IMAGE_NAME:$GITHUB_SHA-$TAG_SUFFIX
# Create and push the architecture-specific git ref
docker manifest create $IMAGE_NAME:$GITHUB_REF_NAME --amend $IMAGE_NAME:$GITHUB_SHA-$TAG_SUFFIX
docker manifest push $IMAGE_NAME:$GITHUB_REF_NAME
# Tag "main" as latest (stable branch) architecture specific
if [[ "$GITHUB_REF_NAME" == "main" ]]; then
docker manifest create $IMAGE_NAME:latest --amend $IMAGE_NAME:$GITHUB_SHA-$TAG_SUFFIX
docker manifest push $IMAGE_NAME:latest
fi
- name: Publish to GitHub Container Registry
env:
IMAGE_SUFFIX_AMD64: amd64
IMAGE_SUFFIX_ARM64V8: arm64v8
TARGET_NAME: ${{ matrix.oci-target }}
IMAGE_NAME: ghcr.io/${{ github.repository }}
if: github.event_name != 'pull_request'
run: |
docker load -i oci-image-${{ matrix.oci-target }}.tar.gz
IMAGE_ID=$(docker images -q conduit:main)
# Tag and push the architecture specific images
if [[ "$TARGET_NAME" = *"x86_64"* ]]; then
if [[ "$TARGET_NAME" = *"jemalloc"* ]]; then
docker tag $IMAGE_ID $IMAGE_NAME:$GITHUB_SHA-jemalloc-$IMAGE_SUFFIX_AMD64
docker push $IMAGE_NAME:$GITHUB_SHA-jemalloc-$IMAGE_SUFFIX_AMD64
else
docker tag $IMAGE_ID $IMAGE_NAME:$GITHUB_SHA-$IMAGE_SUFFIX_AMD64
docker push $IMAGE_NAME:$GITHUB_SHA-$IMAGE_SUFFIX_AMD64
fi fi
elif [[ "$TARGET_NAME" = *"aarch64"* ]]; then
if [[ "$TARGET_NAME" = *"jemalloc"* ]]; then # Create and push SHA specific manifest
docker tag $IMAGE_ID $IMAGE_NAME:$GITHUB_SHA-jemalloc-$IMAGE_SUFFIX_ARM64V8 docker manifest create $DOCKER_IMAGE_NAME:$SHA_TAG \
docker push $IMAGE_NAME:$GITHUB_SHA-jemalloc-$IMAGE_SUFFIX_ARM64V8 --amend $DOCKER_IMAGE_NAME:${{ github.sha }}-x86_64-jemalloc \
else --amend $DOCKER_IMAGE_NAME:${{ github.sha }}-aarch64-jemalloc
docker tag $IMAGE_ID $IMAGE_NAME:$GITHUB_SHA-jemalloc-$IMAGE_SUFFIX_ARM64V8 docker manifest push $DOCKER_IMAGE_NAME:$SHA_TAG
docker push $IMAGE_NAME:$GITHUB_SHA-jemalloc-$IMAGE_SUFFIX_ARM64V8
# Update and push branch or latest manifest
docker manifest create $DOCKER_IMAGE_NAME:$BRANCH_TAG \
--amend $DOCKER_IMAGE_NAME:${{ github.sha }}-x86_64-jemalloc \
--amend $DOCKER_IMAGE_NAME:${{ github.sha }}-aarch64-jemalloc
docker manifest push $DOCKER_IMAGE_NAME:$BRANCH_TAG
- name: Create and Push Manifest to GitHub Container Registry
run: |
GHCR_IMAGE_NAME="ghcr.io/${{ github.repository }}"
BRANCH_NAME="${{ github.ref_name }}"
SHA_TAG="${BRANCH_NAME}-${{ github.sha }}"
BRANCH_TAG=$BRANCH_NAME
if [ "$BRANCH_NAME" == "main" ]; then
BRANCH_TAG="latest"
fi fi
fi
# Create and push SHA specific manifest
# Tag and push the architecture specific git ref docker manifest create $GHCR_IMAGE_NAME:$SHA_TAG \
if [[ "$TARGET_NAME" = *"x86_64"* ]]; then --amend $GHCR_IMAGE_NAME:${{ github.sha }}-x86_64-jemalloc \
if [[ "$TARGET_NAME" = *"jemalloc"* ]]; then --amend $GHCR_IMAGE_NAME:${{ github.sha }}-aarch64-jemalloc
docker manifest create $IMAGE_NAME:$GITHUB_REF_NAME --amend $IMAGE_NAME:$GITHUB_SHA-jemalloc-$IMAGE_SUFFIX_AMD64 docker manifest push $GHCR_IMAGE_NAME:$SHA_TAG
docker manifest push $IMAGE_NAME:$GITHUB_REF_NAME
else # Update and push branch or latest manifest
docker manifest create $IMAGE_NAME:$GITHUB_REF_NAME --amend $IMAGE_NAME:$GITHUB_SHA-$IMAGE_SUFFIX_AMD64 docker manifest create $GHCR_IMAGE_NAME:$BRANCH_TAG \
docker manifest push $IMAGE_NAME:$GITHUB_REF_NAME --amend $GHCR_IMAGE_NAME:${{ github.sha }}-x86_64-jemalloc \
fi --amend $GHCR_IMAGE_NAME:${{ github.sha }}-aarch64-jemalloc
elif [[ "$TARGET_NAME" = *"aarch64"* ]]; then docker manifest push $GHCR_IMAGE_NAME:$BRANCH_TAG
if [[ "$TARGET_NAME" = *"jemalloc"* ]]; then
docker manifest create $IMAGE_NAME:$GITHUB_REF_NAME --amend $IMAGE_NAME:$GITHUB_SHA-jemalloc-$IMAGE_SUFFIX_ARM64V8
docker manifest push $IMAGE_NAME:$GITHUB_REF_NAME
else
docker manifest create $IMAGE_NAME:$GITHUB_REF_NAME --amend $IMAGE_NAME:$GITHUB_SHA-$IMAGE_SUFFIX_ARM64V8
docker manifest push $IMAGE_NAME:$GITHUB_REF_NAME
fi
fi
# Tag "main" as latest (stable branch) architecture specific
if [[ "$GITHUB_REF_NAME" = "main" ]]; then
if [[ "$TARGET_NAME" = *"x86_64"* ]]; then
if [[ "$TARGET_NAME" = *"jemalloc"* ]]; then
docker manifest create $IMAGE_NAME:latest --amend $IMAGE_NAME:$GITHUB_SHA-jemalloc-$IMAGE_SUFFIX_AMD64
docker manifest push $IMAGE_NAME:latest
else
docker manifest create $IMAGE_NAME:latest --amend $IMAGE_NAME:$GITHUB_SHA-$IMAGE_SUFFIX_AMD64
docker manifest push $IMAGE_NAME:latest
fi
elif [[ "$TARGET_NAME" = *"aarch64"* ]]; then
if [[ "$TARGET_NAME" = *"jemalloc"* ]]; then
docker manifest create $IMAGE_NAME:latest --amend $IMAGE_NAME:$GITHUB_SHA-jemalloc-$IMAGE_SUFFIX_ARM64V8
docker manifest push $IMAGE_NAME:latest
else
docker manifest create $IMAGE_NAME:latest --amend $IMAGE_NAME:$GITHUB_SHA-$IMAGE_SUFFIX_ARM64V8
docker manifest push $IMAGE_NAME:latest
fi
fi
fi