From c83acabfb0fb404cbbe28bf1d06475b348643461 Mon Sep 17 00:00:00 2001 From: strawberry Date: Wed, 17 Jan 2024 19:58:10 -0500 Subject: [PATCH] return proper error if we fail to convert to canonical JSON Signed-off-by: strawberry --- src/service/rooms/timeline/mod.rs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/service/rooms/timeline/mod.rs b/src/service/rooms/timeline/mod.rs index 493938a9..11f1d701 100644 --- a/src/service/rooms/timeline/mod.rs +++ b/src/service/rooms/timeline/mod.rs @@ -814,8 +814,10 @@ impl Service { } // Hash and sign - let mut pdu_json = - utils::to_canonical_object(&pdu).expect("event is valid, we just created it"); + let mut pdu_json = utils::to_canonical_object(&pdu).map_err(|e| { + error!("Failed to convert PDU {:?} to canonical JSON: {}", &pdu, e); + Error::bad_database("Failed to convert PDU to canonical JSON.") + })?; pdu_json.remove("event_id");