magmaus3/continuwuity
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

use swap_remove instead of remove in a few places

Browse source 
`swap_remove` is faster if we don't care about the order (O(1))

Signed-off-by: strawberry <strawberry@puppygock.gay>
This commit is contained in:
strawberry 2024-06-01 00:22:50 -04:00
parent b63937af0b
commit f6fa2a4f65
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/api/client_server/alias.rs
View file

@ -247,13 +247,13 @@ fn room_available_servers(
.iter() .iter()
.position(|server_name| server_is_ours(server_name)) .position(|server_name| server_is_ours(server_name))
{ {
servers.remove(server_index); servers.swap_remove(server_index);
servers.insert(0, services().globals.server_name().to_owned()); servers.insert(0, services().globals.server_name().to_owned());
} else if let Some(alias_server_index) = servers } else if let Some(alias_server_index) = servers
.iter() .iter()
.position(|server| server == room_alias.server_name()) .position(|server| server == room_alias.server_name())
{ {
servers.remove(alias_server_index); servers.swap_remove(alias_server_index);
servers.insert(0, room_alias.server_name().into()); servers.insert(0, room_alias.server_name().into());
} }

2
src/api/server_server.rs
View file

@ -1922,7 +1922,7 @@ pub(crate) async fn get_room_information_route(
.iter() .iter()
.position(|server| server == services().globals.server_name()) .position(|server| server == services().globals.server_name())
{ {
servers.remove(server_index); servers.swap_remove(server_index);
servers.insert(0, services().globals.server_name().to_owned()); servers.insert(0, services().globals.server_name().to_owned());
} }

2
src/service/rooms/timeline/mod.rs
View file

@ -1078,7 +1078,7 @@ impl Service {
.into_iter() .into_iter()
.position(|server_name| server_is_ours(&server_name)) .position(|server_name| server_is_ours(&server_name))
{ {
servers.remove(server_index); servers.swap_remove(server_index);
} }
servers.sort_unstable(); servers.sort_unstable();