From fc1834d629620d430cbc49e4f4f5beaff5710d5e Mon Sep 17 00:00:00 2001 From: strawberry Date: Sun, 1 Sep 2024 00:44:22 -0400 Subject: [PATCH] use codeblocks instead of HTML tables for some admin commands Signed-off-by: strawberry --- src/admin/room/commands.rs | 27 +++++---------------------- src/admin/user/commands.rs | 25 +++---------------------- 2 files changed, 8 insertions(+), 44 deletions(-) diff --git a/src/admin/room/commands.rs b/src/admin/room/commands.rs index 2e14a849..fff5e5b6 100644 --- a/src/admin/room/commands.rs +++ b/src/admin/room/commands.rs @@ -1,9 +1,7 @@ -use std::fmt::Write; - use conduit::Result; use ruma::events::room::message::RoomMessageEventContent; -use crate::{admin_command, escape_html, get_room_info, PAGE_SIZE}; +use crate::{admin_command, get_room_info, PAGE_SIZE}; #[admin_command] pub(super) async fn list_rooms( @@ -61,29 +59,14 @@ pub(super) async fn list_rooms( }; let output_plain = format!( - "Rooms:\n{}", + "Rooms ({}):\n```\n{}\n```", + rooms.len(), rooms .iter() .map(|(id, members, name)| format!("{id}\tMembers: {members}\tName: {name}")) .collect::>() .join("\n") ); - let output_html = format!( - "\n\t\t\n{}
Room list - page \ - {page}
idmembersname
", - rooms - .iter() - .fold(String::new(), |mut output, (id, members, name)| { - writeln!( - output, - "{}\t{}\t{}", - escape_html(id.as_ref()), - members, - escape_html(name) - ) - .expect("should be able to write to string buffer"); - output - }) - ); - Ok(RoomMessageEventContent::text_html(output_plain, output_html)) + + Ok(RoomMessageEventContent::notice_markdown(output_plain)) } diff --git a/src/admin/user/commands.rs b/src/admin/user/commands.rs index b84fe873..2d5d1ead 100644 --- a/src/admin/user/commands.rs +++ b/src/admin/user/commands.rs @@ -13,7 +13,7 @@ use ruma::{ use serde_json::value::to_raw_value; use crate::{ - admin_command, escape_html, get_room_info, + admin_command, get_room_info, utils::{parse_active_local_user_id, parse_local_user_id}, }; @@ -320,7 +320,7 @@ pub(super) async fn list_joined_rooms(&self, user_id: String) -> Result ResultRooms {user_id} Joined \ - ({})\nid\tmembers\tname\n{}", - rooms.len(), - rooms - .iter() - .fold(String::new(), |mut output, (id, members, name)| { - writeln!( - output, - "{}\t{}\t{}", - escape_html(id.as_ref()), - members, - escape_html(name) - ) - .unwrap(); - output - }) - ); - - Ok(RoomMessageEventContent::text_html(output_plain, output_html)) + Ok(RoomMessageEventContent::notice_markdown(output_plain)) } #[admin_command]