magmaus3/continuwuity
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
3671 commits 37 branches 19 tags 14 MiB
Commit graph

561 commits

Author SHA1 Message Date
Benjamin Lee
8bffcfe82b remove sync response cache 
This cache can serve invalid responses, and has an extremely low hit
rate.

It serves invalid responses because because it's only keyed off
the `since` parameter, but many of the other request parameters also
affect the response or it's side effects. This will become worse once we
implement filtering, because there will be a wider space of parameters
with different responses. This problem is fixable, but not worth it
because of the low hit rate.

The low hit rate is because normal clients will always issue the next
sync request with `since` set to the `prev_batch` value of the previous
response. The only time we expect to see multiple requests with the same
`since` is when the response is empty, but we don't cache empty
responses.

This was confirmed experimentally by logging cache hits and misses over
15 minutes with a wide variety of clients. This test was run on
matrix.computer.surgery, which has only a few active users, but a
large volume of sync traffic from many rooms. Over the test period, we
had 3 hits and 5309 misses. All hits occurred in the first minute, so I
suspect that they had something to do with client recovery from an
offline state. The clients that were connected during the test are:

 - element web
 - schildichat web
 - iamb
 - gomuks
 - nheko
 - fractal
 - fluffychat web
 - fluffychat android
 - cinny web
 - element android
 - element X android

Fixes: #336
 2024-05-17 18:13:11 -04:00
strawberry
f5864afb52 remove namespace check on username login, code simplification on login route 
the namespace check on username login is unnecessary, hashes aren't ever
going to match, and axum auth handles this kind of stuff already

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-15 14:31:35 -04:00
strawberry
434b5118cc media: return our detected MIME type for Content-Type 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-12 15:54:22 -04:00
morguldir
9f19a2025d Revert "feat(membership): check if user already has the membership that is requested to be set" 
This reverts commit 321a6ca0fe.

These checks were not working as intended, resulting in the unban button not working

The join check gets kept since it slightly reduces the amount of sent joins in some cases
This check will probably be replaced soon for a more universal solution to the "made no change" issue

Signed-off-by: morguldir <morguldir@protonmail.com>
 2024-05-10 22:52:44 -04:00
strawberry
328502c1cd dont send avatar url or display name for ban membership events 
the display name or avatar may be offensive

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-09 17:44:15 -04:00
strawberry
d15e461303 config option to auto-remediate bad users joining bad rooms or servers 
also forgets all rooms upon leave_all_rooms

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-09 17:44:15 -04:00
strawberry
3504e6e724 fix broken reports 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-09 12:33:46 -04:00
strawberry
154b2ab490 media: additional sanitisation on the Content-Disposition filename 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-09 09:53:04 -04:00
strawberry
2231ccf118 return inline Content-Disposition based on the detected file type (e.g. image/video) 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-09 09:53:04 -04:00
strawberry
d4d9f92ade add security response HTTP headers if not present 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-09 09:53:04 -04:00
strawberry
7b25ef2e6c make next_batch token a variable in search, revert threads_until change 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-06 03:45:10 -04:00
strawberry
321e197d8c correct arithmetic adjustments 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-06 03:45:10 -04:00
Xiretza
bbdced9c90 Fix appservice namespace check for room aliases 
Only normal users should be prevented from creating an alias within an
exclusive namespace, not the appservice itself. This mirrors the
behaviour in api/client_server/room.rs on room creation.
 2024-05-06 03:45:10 -04:00
strawberry
0ebb323490 resolve almost all as_conversions lints 
may need further opinion from others on these

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-06 03:45:10 -04:00
strawberry
f8e1255994 presence: set empty string status msg to None 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-06 03:45:10 -04:00
strawberry
b5c0c30a5e resolve half of the integer_arithmetic lints, couple misc changes 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-06 03:45:10 -04:00
strawberry
bfb827a418 send Cache-Control and CORS header for remote thumbnail responses 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-05 16:28:21 -04:00
strawberry
e2fb588a8c sent attachment content-disposition on thumbnails too 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-05 16:28:21 -04:00
strawberry
43c4dfc5df set content-disposition to attachment instead of inline 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-05 16:28:21 -04:00
strawberry
de26bf22dc adjust a couple error codes for room alias getting 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
49078aa836 fix: get the presence of the requested user instead of ourselves 
after getting the shared rooms with the target user, we actually only
get the presence of ourselves instead of the requested user

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
a7f8c848aa refactor and simplify room creation route a bit 
removes a couple unnecessary checks, uses our room_id ruma request field

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
0223386243 remove this unnecessary log, use debug_warn 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
a496cc4705 dedupe version getting code, rename to CONDUWUIT_VERSION_EXTRA 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
Charles Hall
a01a7e1219 improve "Leave event has no state" log 
To include the user, room, and event ID.

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
1464b30433 add workaround for room creation initial_state event content as {}, slight refactor 
this will simply skip over the events

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
f4a2b39d55 split up alias.rs a bit (alias checks and room alias server name stuff) 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
e00b65b0e0 use ok_or_else instead of ok_or for backup.rs 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
beeacd4ef1 initialise capabilities with default constructor 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
e5735c81ed dedupe half of account/room data config.rs code 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
b17ccdadd2 dedupe some code in state.rs 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
6021cb0a1f partially revert this 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
0b39bb813e tiny refactoring, split out report_event_route a bit 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
ed86a4aa9e slight misc adjustments 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
76c5942b4f use user_is_local and server_is_ours more, remove few double filters 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
9931e60050 use single global function for server name local and user local checking 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
450f15df4f admin debug command to fetch a server's true destination 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
Jason Volk
a124122dd4 daily logging improvements 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-04-26 02:03:40 -04:00
Jason Volk
00ce43d739 remove redundant timers 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-04-26 02:03:40 -04:00
Jason Volk
b01d25277d fix remote media error propagation 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-04-26 02:03:40 -04:00
Jason Volk
b3984f5337 deduplicate cache control into constant 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-04-26 02:03:40 -04:00
Jason Volk
7e5ed199c9 deduplicate media handler bodies; minor reorg 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-04-26 02:03:40 -04:00
strawberry
a81563244f restricted room join typo 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-04-26 02:03:40 -04:00
Jason Volk
15a990dc25 improve various logging 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-04-26 02:03:40 -04:00
strawberry
1b41e35f1d use HTTP 403 (forbidden) instead of HTTP 400 for membership failed auth checks 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-04-26 02:03:40 -04:00
strawberry
eb10e7d39b fix(appservices): don't perform identity assertion when auth is optional 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-04-26 02:03:40 -04:00
strawberry
66bb88a03a make everything pub(crate) instead of pub 
conduwuit is not a library

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-04-26 02:03:40 -04:00
strawberry
472c32f453 conduit "library" delete, resolve some warnings from that 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-04-26 02:03:40 -04:00
strawberry
b8a748815a dont allow admin room to be made world readable 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-04-26 02:03:40 -04:00
strawberry
acbe3bfbda use global valid_cidr_range everywhere else 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-04-26 02:03:40 -04:00