magmaus3/continuwuity
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
3983 commits 37 branches 19 tags 14 MiB
Commit graph

763 commits

Author SHA1 Message Date
strawberry
38238c309f appservices: remove unnecessary services() call for self 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-05 18:18:08 -04:00
strawberry
0857fe7907 abstract+add more "users in room" accessors, check membership state on active_local_joined_users_in_room 
`roomuserid_joined` cf seems unreliable, so in the mean time we need to check
membership state (or maybe this is a more reliable check anyways)

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-05 18:18:08 -04:00
strawberry
c738c119f8 delete unnecessary real_users_cache, fix overwriting push_target iter, add proper function for getting local active users in room 
this `real_users_cache` cache seems weird, and i have no idea what
prompted its creation upstream. perhaps they did this because
sqlite was very slow and their rocksdb setup is very poor, so
a "solution" was to stick member counts in memory.
slow iterators, scanning, etc do not apply to conduwuit where
our rocksdb is extremely tuned, and i seriously doubt something
like this would have any real world net-positive performance impact.

also for some reason, there is suspicious logic where we
overwrite the entire push target collection.

both of these things could be a potential cause for receiving
notifications in rooms we've left.

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-05 18:18:08 -04:00
Jason Volk
732e8b82aa Abstract password hashing into util. 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-05 03:00:23 +00:00
strawberry
919735b4ce remove usages of &String and &Owned[..] 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-03 14:17:42 -04:00
strawberry
ff7dfec74c slightly cleanup update check 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-03 14:17:42 -04:00
strawberry
84290bd668 update deps, remove unnecessary zstd crate, pin rust-rocksdb rev 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-03 14:17:32 -04:00
strawberry
83220b43a2 use saturating_add and vec with_capacity in even more places 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-03 00:10:28 -04:00
strawberry
f6fa2a4f65 use swap_remove instead of remove in a few places 
`swap_remove` is faster if we don't care about the order (O(1))

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-03 00:10:28 -04:00
strawberry
173ff26eb6 disable URL previews by default upon admin room creation 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-03 00:10:28 -04:00
strawberry
9f359e0550 make resolve_state public to resolve new forced compressed room state 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-02 23:53:31 -04:00
strawberry
ffdf47d1ea add latest_pdu_in_room timeline function 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-02 23:53:31 -04:00
strawberry
1ac72ab914 init a few state hashmaps using with_capacity 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-06-02 23:53:31 -04:00
Jason Volk
887496d040 consolidate default cargo features 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 23:01:12 +00:00
Jason Volk
102bd1b4a6 use debug_warn for parse_incoming_pdu err results. 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 23:01:12 +00:00
Jason Volk
90d9a997a5 split / cleanup core utils. 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 20:17:45 +00:00
Jason Volk
f1d1366129 split resolve_actual_dest 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 20:17:45 +00:00
Jason Volk
ba48758b89 impl fmt::Display for FedDest 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 20:17:45 +00:00
Jason Volk
9df5265c00 split sending resolver into unit. 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 20:17:45 +00:00
Jason Volk
53fe2362fc Fix path-buf-push-overwrite 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 12:34:05 -04:00
Jason Volk
4521e93d04 Fix stable-sort-primitive 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 12:34:05 -04:00
Jason Volk
0f3d43153b Fix unused-self 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 12:34:05 -04:00
Jason Volk
68cbf19154 Fix items-after-statements 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 12:34:05 -04:00
Jason Volk
02081b66c4 Fix some unnecessary-unwraps w/ addl cleanup/simplification. 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 12:34:05 -04:00
Jason Volk
14039d9df4 cleanup unused extern crates. 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 12:34:05 -04:00
Jason Volk
eed8a2a801 add and sort incomplete package metadata 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 12:34:05 -04:00
Jason Volk
6d1144bb69 move unix socket unlink from services to router 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-06-02 01:20:28 -04:00
Jason Volk
b94045a468 dissolve key_value/* 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-05-27 18:16:23 -04:00
strawberry
68fffe8e96 check room ACLs on sender user's server for incoming PDUs 
`handle_incoming_pdu`

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-27 18:16:23 -04:00
strawberry
6269822613 actually fix all let_underscore_must_use lints 
CI caught some more

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-25 22:28:43 -04:00
strawberry
5215fbe695 drop redaction calculated hash log to debug_info 
this is normal redactions. no valid reason this needs to be
warn as it just causes confusion.

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-25 22:28:43 -04:00
strawberry
32161801ed use/enable let_underscore_must_use lint 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-25 22:28:43 -04:00
strawberry
e098448b9d init a few vecs in event_handler using with_capacity 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-25 22:28:43 -04:00
strawberry
d49507bc21 media: decomplexify get_all_media_keys for deleting all MXC URIs 
wow this was terrible, early strawberry code

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-25 22:28:43 -04:00
Jason Volk
1f3a9a40e5 lint clippy::collapsible_match (nightly) 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-05-21 20:22:17 -04:00
Jason Volk
6c1434c165 Hot-Reloading Refactor 
Signed-off-by: Jason Volk <jason@zemos.net>
 2024-05-21 20:22:17 -04:00
slonkazoid
ae1a4fd283 add modification time fallback if birth time is not supported on this platform 2024-05-21 16:58:30 -04:00
Benjamin Lee
8bffcfe82b remove sync response cache 
This cache can serve invalid responses, and has an extremely low hit
rate.

It serves invalid responses because because it's only keyed off
the `since` parameter, but many of the other request parameters also
affect the response or it's side effects. This will become worse once we
implement filtering, because there will be a wider space of parameters
with different responses. This problem is fixable, but not worth it
because of the low hit rate.

The low hit rate is because normal clients will always issue the next
sync request with `since` set to the `prev_batch` value of the previous
response. The only time we expect to see multiple requests with the same
`since` is when the response is empty, but we don't cache empty
responses.

This was confirmed experimentally by logging cache hits and misses over
15 minutes with a wide variety of clients. This test was run on
matrix.computer.surgery, which has only a few active users, but a
large volume of sync traffic from many rooms. Over the test period, we
had 3 hits and 5309 misses. All hits occurred in the first minute, so I
suspect that they had something to do with client recovery from an
offline state. The clients that were connected during the test are:

 - element web
 - schildichat web
 - iamb
 - gomuks
 - nheko
 - fractal
 - fluffychat web
 - fluffychat android
 - cinny web
 - element android
 - element X android

Fixes: #336
 2024-05-17 18:13:11 -04:00
strawberry
d15e461303 config option to auto-remediate bad users joining bad rooms or servers 
also forgets all rooms upon leave_all_rooms

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-09 17:44:15 -04:00
strawberry
321e197d8c correct arithmetic adjustments 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-06 03:45:10 -04:00
Xiretza
136cb038cf auth_chain: add useful debug logging 2024-05-06 03:45:10 -04:00
strawberry
29babebc4d adminroom: add count to list-joined-rooms user command 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-06 03:45:10 -04:00
strawberry
0ebb323490 resolve almost all as_conversions lints 
may need further opinion from others on these

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-06 03:45:10 -04:00
strawberry
b5c0c30a5e resolve half of the integer_arithmetic lints, couple misc changes 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-06 03:45:10 -04:00
strawberry
43c4dfc5df set content-disposition to attachment instead of inline 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-05 16:28:21 -04:00
strawberry
75b9332917 dont allow creating remote users in admin room 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
fa0bdd431b add destination to X-Matrix Authorization outbound requests 
we were already validating this for inbound requests

Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
c4beb7d462 dont return "Allocator" header for server memory-usage if empty 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
0f13ada300 return more user-friendly message for debug memory-stats 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00
strawberry
a496cc4705 dedupe version getting code, rename to CONDUWUIT_VERSION_EXTRA 
Signed-off-by: strawberry <strawberry@puppygock.gay>
 2024-05-03 01:52:29 -04:00