revenge-mod/Revenge
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Plugins] Properly handle errors in UI

Browse source
This commit is contained in:
Beef 2023-02-20 18:43:50 +00:00
parent a039d183b7
commit 77dd4503b7
2 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lib/plugins.ts
View file

@ -100,7 +100,7 @@ export function stopPlugin(id: string, disable = true) {
if (!pluginRet) throw new Error("Attempted to stop a non-started plugin"); if (!pluginRet) throw new Error("Attempted to stop a non-started plugin");
try { try {
loadedPlugins[plugin.id]?.onUnload?.(); pluginRet.onUnload?.();
} catch(e) { } catch(e) {
logger.error(`Plugin ${plugin.id} errored whilst unloading`, e); logger.error(`Plugin ${plugin.id} errored whilst unloading`, e);
} }

14
src/ui/settings/components/PluginCard.tsx
View file

@ -71,7 +71,11 @@ export default function PluginCard({ plugin }: PluginCardProps) {
style={RN.Platform.OS === "android" && { marginVertical: -15 }} style={RN.Platform.OS === "android" && { marginVertical: -15 }}
value={plugin.enabled} value={plugin.enabled}
onValueChange={(v: boolean) => { onValueChange={(v: boolean) => {
if (v) startPlugin(plugin.id); else stopPlugin(plugin.id); try {
if (v) startPlugin(plugin.id); else stopPlugin(plugin.id);
} catch (e) {
showToast((e as Error).message, getAssetIDByName("Small"));
}
}} }}
/> />
} }
@ -88,8 +92,12 @@ export default function PluginCard({ plugin }: PluginCardProps) {
cancelText: "Cancel", cancelText: "Cancel",
confirmColor: "red", confirmColor: "red",
onConfirm: () => { onConfirm: () => {
removePlugin(plugin.id); try {
setRemoved(true); removePlugin(plugin.id);
setRemoved(true);
} catch (e) {
showToast((e as Error).message, getAssetIDByName("Small"));
}
} }
})} })}
> >